Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[health] Remove automatically added workout permissions #1055

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ciriousjoker
Copy link
Contributor

@ciriousjoker ciriousjoker commented Oct 5, 2024

Workouts don't necessarily have distances or burnt calories. The health plugin automatically requests these permissions with no way to disable it.

Solution

  • Don't automatically request those permissions and make the package consumer declare the permissions manually

Solves these

Keep in mind that this is a breaking change, since all users who previously relied on the permission from being added automatically now need to declare it themselves.
This PR only updates the code, but not the changelog or the documentation.

@bardram bardram requested a review from iarata October 29, 2024 10:47
@iarata iarata added the improvement an improvement label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement an improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants