Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor settings.gradle to remove duplicate module references #898

Closed
wants to merge 1 commit into from

Conversation

acezard
Copy link
Contributor

@acezard acezard commented Aug 18, 2023

In this PR, we've made the following improvements to the settings.gradle file:

  • Removed the redundant inclusion of the @fengweichong/react-native-gzip module. It was creating an error because of an import duplication: Multiple projects in the build are located in the same directory: /home/anc/cozy/cozy-react-native/node_modules/@fengweichong/react-native-gzip/android
  • Formatted the file for better readability by adding spaces between module includes.

By making these changes, we've resolved the Java workspace error that was caused due to multiple projects being located in the same directory.

remove redundant inclusions
@Ldoppea
Copy link
Member

Ldoppea commented Aug 22, 2023

Just to be sure, you removed react-native-gzip from settings.gadle because itwas an import duplication. But where is it imported at the first place?

Also you removed duplication for react-native-fs but did not mention it in the PR description.

@acezard acezard closed this Oct 18, 2023
@acezard acezard deleted the fix--remove-java-errors branch October 18, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants