feat: More logs in konnectors #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These logs will be sent by the flagship app on restart anyway. These logs are still usefull to debug authentication errors.
Before we expected the job to contain and display this error but if the error occurs before the job is created (in authentication phase), the error won't be added to the logs and it makes it difficult to debug.
doubleface
force-pushed
the
feat/allwaysSendKonnectorLogs
branch
from
d1c5323
to
1729e64
Compare
LucsT
approved these changes
Aug 10, 2023
Crash--
approved these changes
Aug 10, 2023
Ldoppea
approved these changes
Aug 10, 2023
added 2 commits
August 10, 2023 11:39
This will put clisk konnector logs in proper order.
doubleface
force-pushed
the
feat/allwaysSendKonnectorLogs
branch
from
a7e6463
to
58f456a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Before merging this PR, the following things must have been done: