fix: Make i18n work on iOS #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zatteo
approved these changes
Jul 24, 2023
`react-native-localize` has been downgraded to `2.2.6` to make it compatible with iOS `11` After `3.0.0` this library requires iOS `12.4` and react-native `0.70` so we should not upgrade to this version until we do the react-native migration and chose to drop iOS `11` support
`Intl` is only provided on Android's Hermes but is not available on iOS so we should add a polyfill to use it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-native-localizehas been upgraded to2.2.6to make itcompatible with iOS
11After
3.0.0this library requires iOS12.4and react-native0.70so we should not upgrade to this version until we do the react-native
migration and chose to drop iOS
11supportAlso
Intlis only provided on Android's Hermes but is not available on iOSso we should add a polyfill to use it