feat: Add generic error page and replace old ErrorView #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acezard
reviewed
Jul 20, 2023
There was a problem hiding this comment.
Not sure about that here, for me makeHtmlErrorPage is linked to view and not to domain (business logic)
There was a problem hiding this comment.
I moved it here: bf91bb6
I chose to merge the type definitions in the same file, are you ok with that?
| }: MakeErrorPageProps): string => { | ||
| const dimensions = getDimensions() | ||
| const navbarHeight = dimensions.navbarHeight | ||
| const statusBarHeight = dimensions.statusBarHeight | ||
|
|
||
| const theme = invertedTheme ? 'theme-inverted' : 'theme-light' |
There was a problem hiding this comment.
can't the string be passed directly as an enum in props? that way this view file doesn't handle this trinary operator logic
There was a problem hiding this comment.
I did the change here: a821d18
1 task
The only thing we haven't done yet is to display SVG images in the native views. |
Ldoppea
force-pushed
the
fix/not_onboarded_cozy
branch
from
8786022
to
5f33b1b
Compare
Ldoppea
force-pushed
the
feat/generic_error_page
branch
from
8360d04
to
030dfbd
Compare
Ldoppea
force-pushed
the
fix/not_onboarded_cozy
branch
from
5f33b1b
to
9c02f92
Compare
Ldoppea
force-pushed
the
feat/generic_error_page
branch
3 times, most recently
from
7536879
to
91415ee
Compare
Ldoppea
force-pushed
the
fix/not_onboarded_cozy
branch
from
9c02f92
to
6616e21
Compare
In the next commit we will want to display an Error page using a light background This commits add the possibility to chose between light and inverted themes Default theme is inverted to keep compatibility with existing error pages
In case of unexpected error we want to display a generic error page that displays the error message and allow to display the error's technical details if needed This page is meant to replace the current ErrorView used in Login and Onboarding screens. This replacement will be done in the following commit
Current ErrorView implementation doesn't contains any design so the displayed error is very raw and is not user friendly We want to improve this UI but instead of modifying the ErrorView we replace it by the new generic error page from ErrorScreen. This would improve code homogeneity Also we now use the `navigateToError` function to analyse the error object and chose which error to display
Contact email is already displayed on the error body so we don't need the footer to be displayed
Ldoppea
force-pushed
the
feat/generic_error_page
branch
from
91415ee
to
7c02549
Compare
acezard
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current ErrorView implementation doesn't contains any design so the displayed error is very raw and is not user friendly
We want to improve this UI but instead of modifying the ErrorView we replace it by a new generic error page from ErrorScreen. This would improve code homogeneity
Also we now use the
navigateToErrorfunction to analyse the error object and chose which error to displayResult page
Note that the error message is from code, so it is not translated
Result page after clicking "voir les détails de l'erreur"
Note that the details are displayed using a js
alert()so we cannot copy its content, but it should be ok for a first iteration