feat: Allow the user to choose to save debug traces on error (SCR-872) #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature is still behind the `clisk.automatic.html-on-error` flag because it still needs some UI work. When an unexpected error is raised from a clisk konnector, the current page in the worker is displayed to user and a button to send traces is proposed which does exactly the same as the `clisk.html-on-error` flag.
doubleface
changed the title
KillianCourvoisier
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is still behind the
clisk.automatic.html-on-errorflagbecause it still needs some UI work.
When an unexpected error is raised from a clisk konnector, the current
page in the worker is displayed to user and a button to send traces is
proposed which does exactly the same as the
clisk.html-on-errorflag.Checklist
Before merging this PR, the following things must have been done if relevant: