Quality Checks

feat: Check that the sourceAccountIdentifier corresponds to account name (SCR-869) #2016

Triggered via pull request October 23, 2024 07:26

doubleface

opened #1255

feat/cliskMultiAccount

Status Failure

Total duration 2m 58s

Artifacts –

quality_checks.yml

on: pull_request

Quality Checks

2m 49s

Annotations

10 errors and 11 warnings

Quality Checks: src/libs/ReactNativeLauncher.spec.js#L39

Replace `·_id:·'normal_account_id',·auth:·{·accountName:·'testsourceaccountidentifier'}` with `⏎····_id:·'normal_account_id',⏎····auth:·{·accountName:·'testsourceaccountidentifier'·}⏎·`

Quality Checks: src/libs/ReactNativeLauncher.spec.js#L572

Delete `,`

Quality Checks: src/libs/ReactNativeLauncher.spec.js#L580

Replace `⏎········.mockImplementation((method)` with `.mockImplementation(method`

Quality Checks: src/libs/ReactNativeLauncher.spec.js#L582

Delete `··`

Quality Checks: src/libs/ReactNativeLauncher.spec.js#L583

Delete `··`

Quality Checks: src/libs/ReactNativeLauncher.spec.js#L584

Delete `··`

Quality Checks: src/libs/ReactNativeLauncher.spec.js#L585

Delete `··`

Quality Checks: src/libs/ReactNativeLauncher.spec.js#L586

Delete `··`

Quality Checks: src/libs/ReactNativeLauncher.spec.js#L587

Delete `··`

Quality Checks: src/libs/ReactNativeLauncher.spec.js#L591

Replace `message:·'WRONG_ACCOUNT_IDENTIFIER'` with `⏎········message:·'WRONG_ACCOUNT_IDENTIFIER'⏎······`

Quality Checks

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Quality Checks: src/app/domain/authentication/services/SynchronizeService.ts#L1

There should be at least one empty line between import groups

Quality Checks: src/app/domain/backup/services/manageAlbums.ts#L110

Forbidden non-null assertion

Quality Checks: src/app/domain/backup/services/manageLocalBackupConfig.ts#L146

Forbidden non-null assertion

Quality Checks: src/app/domain/backup/services/manageProgress.ts#L1

There should be no empty line within import group

Quality Checks: src/app/domain/backup/services/uploadMedia.android.ts#L20

Forbidden non-null assertion

Quality Checks: src/app/domain/errors/navigateToError.ts#L51