Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow remote request on web environment #1547

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: Allow remote request on web environment #1547

merged 1 commit into from
Oct 17, 2024

Conversation

paultranvan
Copy link
Contributor

When using PouchLink in a web environment, we need to pass the cookies through the fetch method in order to authenticate to the stack. Note we didn't have the issue before we were using PouchLink in a mobile environment, with OAuth authentication.

For more insights, see

https://reqbin.com/code/javascript/lcpj87js/
javascript-fetch-with-credentials

When using PouchLink in a web environment, we need to pass the cookies
through the fetch method in order to authenticate to the stack.
Note we didn't have the issue before we were using PouchLink in a
mobile environment, with OAuth authentication.

For more insights, see
```
https://reqbin.com/code/javascript/lcpj87js/
javascript-fetch-with-credentials
```
Copy link
Member

@cballevre cballevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@paultranvan paultranvan merged commit 5fc39c8 into master Oct 17, 2024
4 checks passed
@paultranvan paultranvan deleted the web-pouch branch October 17, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants