Revert "Use traces to extract the input for settlement::Observer (#…
#3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinquaXD
approved these changes
Jan 16, 2025
|
I will do a round of testing on all nodes and will probably implement:
In the meantime, merging this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts #3233
None of the Arbitrum nodes supports
trace_transaction. Supposedly,arbtrace_transactionshould be used instead, but I couldn't make it work.Also, not all backup nodes (read alchemy) for other networks (base, gc) support
trace_transaction. I noticed that alchemy supportsdebug_traceTransactionthat could be used instead.Overall, I should have checked this before merging the PR. I decided to revert this PR since, right now, Arbitrum staging is unable to work properly, and also, even with specific/per_chain implementation I am not sure I will be able to make it work with all PRIMARY/BACKUP nodes on ALL networks. This needs throughout testing first.