Reduced logging verbosity and added context through grouping and conditional logging #241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked at the cmd directory in the “bsp-agent” and came up with potential solutions to optimize logging in the cmd directory
I discovered the code by default uses “log.InfoLevel” whenever logs are being generated excessively, so I introduced codes for “log.WarnLevel” and “log.ErrorLevel” with the line “log.SetLevel(log.WarnLevel)” to set the log level to “WarnLevel”, meaning only warnings and errors will be logged.
I also noticed that the code logs messages at various points, like startup and configuration settings. I decided to modify the logging frequency by setting “log.SetLevel(log.WarnLevel), to limit logging to warnings and errors by default.
I also disabled “log.SetReportCaller(false)” preventing redundant caller information and reducing log size. This helps to reduce the logging verbosity.
You would also notice the introduction of “log.WithFields” which adds context to log messages, enabling better grouping and filtering.
I also added warning-level logs for noteworthy events or disabled features.