Skip to content

Commit

Permalink
fix docker upload gradle task params (Consensys#8232)
Browse files Browse the repository at this point in the history
  • Loading branch information
mehdi-aouadi authored Apr 20, 2024
1 parent 1ded471 commit 3d9bb08
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ commands:
name: "Publish Docker Images"
command: |
docker login --username "${DOCKER_USER_RW}" --password "${DOCKER_PASSWORD_RW}"
./gradlew --no-daemon --parallel "-Pbranch=${CIRCLE_BRANCH} -PincludeCommitHashInDockerTag=<< pipeline.parameters.include_commit_hash_in_docker_tag >>" uploadDocker
./gradlew --no-daemon --parallel -Pbranch=${CIRCLE_BRANCH} -PincludeCommitHashInDockerTag=<< pipeline.parameters.include_commit_hash_in_docker_tag >> uploadDocker
notify:
description: "Notify Slack"
Expand Down Expand Up @@ -464,7 +464,7 @@ jobs:
- run:
name: Create and publish docker manifest
command: |
./gradlew --no-daemon --parallel "-PincludeCommitHashInDockerTag=<< pipeline.parameters.include_commit_hash_in_docker_tag >>" manifestDocker
./gradlew --no-daemon --parallel manifestDocker
- notify

extractAPISpec:
Expand Down
4 changes: 2 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -633,10 +633,10 @@ task manifestDocker {
}

for (def tag in tags) {
platforms.forEach { platform -> cmd += "${tag}-${platform}${commitHashTag} " }
platforms.forEach { platform -> cmd += "${tag}-${platform} " }
exec {
executable executableAndArg[0]
args executableAndArg[1], "docker manifest create ${tag}${commitHashTag} ${cmd} && docker manifest push ${tag}${commitHashTag}"
args executableAndArg[1], "docker manifest create ${tag} ${cmd} && docker manifest push ${tag}"
}
}
}
Expand Down

0 comments on commit 3d9bb08

Please sign in to comment.