-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move swift and dxpy into extras #150
Draft
jtratner
wants to merge
18
commits into
master
Choose a base branch
from
move-swift-and-dxpy-into-extras
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dxpy pulls in a wide array of (often legacy) packages, skipping the import means we only need to pull it in as necessary which hopefully makes library more useful to others.
make dxpy into an extra as well
include with and without dxpy
Sem-Ver: api-break
Rather than leave the user hanging, show something helpful to the user so they can resolve the situation by installing an additional package. Left this as a separate function so it's easy to test the exception generation fucntion doesn't break without needing to do painful testing contortions. (which should be caught later on by test matrix)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #143 . Makes swift and dxpy actually optional so people can opt into complex dependencies rather than being forced to use 'em, yay!
Tested this out in a codespace:
New traceback:
And then showed results
`cat dxpy.txt`
`cat swift.txt`
`cat dxpy,swift.txt`