Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

add supported versions of python and django #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kreneskyp
Copy link

Adding more tox options to test newer and wider set of python and django version

changes

  • adds tests:
    • python 3.8, 3.9
    • django: 3.1, 3.2, 4.0
  • drops tests:
    • python 3.6
    • django 1.11

How tested

  • changes are tox config, tested with unittests!

@kreneskyp kreneskyp marked this pull request as ready for review February 22, 2022 22:27
Copy link

@ctk3b ctk3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % version typo fix and confirming the tests passed on all configs 😁

Also hi @kreneskyp !

2.2: Django>=2.2,<3.0
3.0: Django>=3.0,<3.1
3.1: Django>=3.1,<3.2
3.2: Django>=2.2,<4.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3.2: Django>=2.2,<4.0
3.2: Django>=3.2,<4.0

@kreneskyp
Copy link
Author

I'm actually having trouble running tests locally. Was hoping this repo had CI hooked up to it still but it apparently does not.

@kreneskyp
Copy link
Author

Also hi @kreneskyp !

oh hey there! @ctk3b

@ctk3b
Copy link

ctk3b commented Feb 22, 2022

Was hoping this repo had CI hooked up to it still but it apparently does not

I don't have admin but if you do, I found it very easy to get set up with github actions and tox https://github.com/insitro/redun/blob/main/.github/workflows/test_pull_request.yml

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants