Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk save via argument to save, update, create #153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bulk save via argument to save, update, create #153

wants to merge 1 commit into from

Conversation

trey-jones
Copy link

Added 'bulk' optional parameter to save, update, and create methods of CouchRest::Model.
This uses couch's bulk_save functionality, which is already abstracted in CouchRest.

@ghempton
Copy link
Contributor

This seems valuable. Any chance this could be merged in?

@samlown
Copy link
Member

samlown commented May 27, 2014

Hey. It looks interesting, although I can't say I've ever needed to use something like this. However, I'm not willing to accept it in its current state. Firstly, there are no tests. Secondly, it seems to me that best approach would be to provide a :bulk => true in the options hash, rather than adding in additional parameter.

Would gladly accept a refactored patch with tests ;-)

@trey-jones
Copy link
Author

Good morning.  I obviously haven’t touched this in quite some time - in fact, the project that I used this for is my only experience with Rails and with couch.  If I have some time later this week I might try and refactor, but if someone else would like to do that, I don’t think the patch was very extensive (just a few lines), and I’m sure a test for it would be equally simple.
— 

Trey Jones
Senior Application Developer
Eyesore, Inc.
(O)678.692.8512
(F)888.742.9041
http://www.eyesoreinc.com

On May 27, 2014 at 6:04:43 AM, Sam Lown ([email protected]) wrote:

Hey. It looks interesting, although I can't say I've ever need to use something like this. However, I'm not willing to accept it in its current state. Firstly, there are no tests. Secondly, it seems to me that best approach would be to provide a :bulk => true in the options hash, rather than adding in additional parameter.

Would gladly accept a refactored patch with tests ;-)


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants