Skip to content

Commit

Permalink
[NO ISSUE]: Fix AzureBlobStorageExternalDatasetOnePartitionTest
Browse files Browse the repository at this point in the history
- user model changes: no
- storage format changes: no
- interface changes: no

details:
- Opening an input stream on empty blobs in azurite throws a null
  pointer exception in versions > 3.31.0.
  Azure/Azurite#2458
- Use a less conflicting port for gcs tests

Change-Id: Ia6dff5172b91f0d0e8a26c0e69aceff3b74896c2
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19147
Integration-Tests: Jenkins <[email protected]>
Tested-by: Jenkins <[email protected]>
Reviewed-by: Murtadha Hubail <[email protected]>
  • Loading branch information
savyasach authored and mhubail committed Nov 30, 2024
1 parent 4572cf4 commit 1e4b8c1
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions asterixdb/asterix-app/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@
<workingDirectory>${project.build.directory}/fake-gcs-server</workingDirectory>
<arguments>
<argument>-port</argument>
<argument>4443</argument>
<argument>24443</argument>
<argument>-scheme</argument>
<argument>http</argument>
<argument>-host</argument>
Expand Down Expand Up @@ -447,7 +447,7 @@
<goal>npm</goal>
</goals>
<configuration>
<arguments>install azurite</arguments>
<arguments>install azurite@3.31.0</arguments>
</configuration>
</execution>
</executions>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public class CloudStorageGCSTest {
private static final String CONFIG_FILE_NAME = "src/test/resources/cc-cloud-storage-gcs.conf";
private static final String DELTA_RESULT_PATH = "results_cloud";
private static final String EXCLUDED_TESTS = "MP";
public static final String MOCK_SERVER_HOSTNAME = "http://127.0.0.1:4443";
public static final String MOCK_SERVER_HOSTNAME = "http://127.0.0.1:24443";
private static final String MOCK_SERVER_PROJECT_ID = "asterixdb-gcs-test-project-id";

public CloudStorageGCSTest(TestCaseContext tcCtx) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,6 @@ storage.partitioning=static
cloud.storage.scheme=gs
cloud.storage.bucket=cloud-storage-container
cloud.storage.region=us-west2
cloud.storage.endpoint=http://127.0.0.1:4443
cloud.storage.endpoint=http://127.0.0.1:24443
cloud.storage.anonymous.auth=true
cloud.storage.cache.policy=selective
2 changes: 1 addition & 1 deletion asterixdb/asterix-cloud/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
<workingDirectory>${project.build.directory}/fake-gcs-server</workingDirectory>
<arguments>
<argument>-port</argument>
<argument>4443</argument>
<argument>24443</argument>
<argument>-scheme</argument>
<argument>http</argument>
<argument>-host</argument>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

public class LSMGCSTest extends AbstractLSMTest {
private static Storage client;
private static final int MOCK_SERVER_PORT = 4443;
private static final int MOCK_SERVER_PORT = 24443;
private static final String MOCK_SERVER_HOSTNAME = "http://127.0.0.1:" + MOCK_SERVER_PORT;
private static final String MOCK_SERVER_REGION = "us-west2"; // does not matter the value
private static final String MOCK_SERVER_PROJECT_ID = "asterixdb-gcs-test-project-id";
Expand Down

0 comments on commit 1e4b8c1

Please sign in to comment.