Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TendermintClientState::verify_header into CGP component #937

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

soareschen
Copy link
Collaborator

Description

This is an experimentation to incrementally refactor the ibc-rs implementation to use context-generic programming, similar to what is done in Hermes SDK.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (553bc79) 67.65% compared to head (06fab7d) 67.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
- Coverage   67.65%   67.46%   -0.20%     
==========================================
  Files         130      131       +1     
  Lines       16415    16463      +48     
==========================================
  Hits        11106    11106              
- Misses       5309     5357      +48     
Files Coverage Δ
...nts/ics07_tendermint/client_state/update_client.rs 79.69% <ø> (ø)
crates/ibc/src/clients/ics07_tendermint/error.rs 58.33% <ø> (ø)
crates/ibc-cosmos-components/src/client/verify.rs 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant