Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rm unnecessary code for eureka #1372

Open
wants to merge 17 commits into
base: rano/eureka/1364
Choose a base branch
from
Open

refactor: rm unnecessary code for eureka #1372

wants to merge 17 commits into from

Conversation

rnbguy
Copy link
Collaborator

@rnbguy rnbguy commented Oct 29, 2024 •
edited
Loading

Closes: #1371

Description

Removes v1 code that are redundant for eureka e.g. ConnectionId, ChannelMsgs.

Caution

Change base to feat/ibc-eureka when #1365 is merged.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@rnbguy rnbguy added the O: eureka Objective: implement IBC Eureka label Oct 29, 2024
@rnbguy rnbguy mentioned this pull request Oct 29, 2024
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soareschen soareschen Awaiting requested review from soareschen

@Farhad-Shabani Farhad-Shabani Awaiting requested review from Farhad-Shabani

Assignees
No one assigned
Labels
O: eureka Objective: implement IBC Eureka
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rnbguy