Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore files with no tests when searching for test files #7541

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Nov 6, 2024

Description

When the script that crawls test files to pick up test names encounters a file in a test directory that does not have any tests it explodes, instead we can just skip those files, and fail only if we have not found any files after crawling the entire directory.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link

sonarcloud bot commented Nov 6, 2024

@chatton chatton merged commit c191b1d into main Nov 7, 2024
70 checks passed
@chatton chatton deleted the cian/skip-files-with-no-tests branch November 7, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants