Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add paginated packet commitments query to channel/v2 #7533

Open
wants to merge 4 commits into
base: feat/ibc-eureka
Choose a base branch
from

Conversation

damiannolan
Copy link
Member

Description

Adds paginated queries for packet commitments in channel/v2.

This will be needed for relayers who will also want to query unreceived packets as packets sent must be first queried for their commitments on a source.

ref: #7478


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Comment on lines +101 to +104
sequence := sdk.BigEndianToUint64([]byte(keySplit[len(keySplit)-1]))
if sequence == 0 {
return types.ErrInvalidPacket
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be handled different to in v1 as we encode the sequence as big endian bytes when storing commitments.

If parsing the keypart as big endian uint64 fails then it will return 0 - an invalid packet sequence, and is the result of corrupted state.

Copy link

sonarcloud bot commented Nov 4, 2024

Quality Gate Failed Quality Gate failed for 'ibc-go'

Failed conditions
64.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@DimitrisJim
Copy link
Contributor

will take on review and merge while Damian's on holiday (and if any nit pops up will push)

@DimitrisJim DimitrisJim self-assigned this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants