Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add redundancy checks for V2 Msgs #7509

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

bznein
Copy link
Contributor

@bznein bznein commented Oct 23, 2024

Description

Notes: will merge after #7464 to make sure the timeout case is not broken here.

I didn't add tests for ALL new code paths. I followed the current structure of tests and basically added V2 cases for equivalent tests. Happy to add more cases if people prefer

closes: #7491


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Failed Quality Gate failed for 'ibc-go'

Failed conditions
67.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bznein bznein merged commit 870e830 into feat/ibc-eureka Nov 4, 2024
130 of 131 checks passed
@bznein bznein deleted the bznein/7491/RedundancyChecks branch November 4, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants