Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: pin x/tx version #22285

Closed
wants to merge 1 commit into from
Closed

Conversation

kocubinski
Copy link
Member

Description

Checking CI


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@github-actions github-actions bot added C:CLI C:x/evidence C:x/upgrade C:x/feegrant C:Cosmovisor Issues and PR related to Cosmovisor C:x/nft C:Confix Issues and PR related to Confix C:x/circuit C:Hubl Tool: Hubl labels Oct 16, 2024
@@ -1,4 +1,6 @@
go 1.21
go 1.23
Copy link
Member

@julienrbrt julienrbrt Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's problematic, we need to downgrade x/tx to go 1.21 in #22281 then (and in CI too)

@julienrbrt
Copy link
Member

As discussed, we won't do it because of api in x/tx, we'll keep a version of x/tx specific to 0.50 until 0.50 is dropped.

@julienrbrt julienrbrt closed this Oct 17, 2024
@julienrbrt julienrbrt deleted the kocu/v50-latest-x-tx branch October 17, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Hubl Tool: Hubl C:x/circuit C:x/evidence C:x/feegrant C:x/nft C:x/upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants