refactor(x/bank/v2): migrate to handlers

[julienrbrt]

Description

Closes: #21577

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• New Features

  • Introduced mechanisms for parameter updates and retrieval within the bank module.
  • Enhanced message and query handling capabilities.

• Bug Fixes

  • Temporarily disabled AutoCLI functionality due to unresolved issues.

• Removals

  • Removed gRPC gateway plugin from build configuration.
  • Eliminated Query and Msg service definitions, impacting parameter access and updates.
  • Deleted message and query server implementations, altering how updates and queries are processed.

• Refactor

  • Shifted to a more modular approach for registering message and query handlers.

[coderabbitai]

Walkthrough

Walkthrough

The pull request introduces significant changes to the bank module in the Cosmos SDK, including the removal of the grpc-gateway plugin configuration, deletion of service definitions for querying and updating parameters, and the introduction of a new handlers structure for managing messages and queries. The AutoCLI functionality is disabled temporarily, and various files related to message and query servers have been removed, indicating a shift towards a more modular design with dedicated handlers.

Changes

Files	Change Summary
x/bank/proto/buf.gen.gogo.yaml	Commented out grpc-gateway plugin configuration, indicating a temporary exclusion from the build.
x/bank/proto/cosmos/bank/v2/query.proto	Removed Query service and its Params method, affecting access to module parameters.
x/bank/proto/cosmos/bank/v2/tx.proto	Removed Msg service and its UpdateParams method, altering parameter update handling.
x/bank/v2/autocli.go	Modified AutoCLIOptions method to return nil, disabling AutoCLI functionality.
x/bank/v2/keeper/handlers.go	Added new handlers struct for managing messages and querying parameters.
x/bank/v2/keeper/msg_server.go	Deleted file containing message server implementation, removing related functionality.
x/bank/v2/keeper/query_server.go	Deleted file containing query server implementation, removing related functionality.
x/bank/v2/module.go	Introduced new message and query handler registration methods, enhancing modularity.
x/bank/v2/types/codec.go	Removed message service registration, simplifying message handling.

Assessment against linked issues

Objective	Addressed	Explanation
Migrate bank/v2 msg/query servers to handlers (#[21577])	✅

Possibly related PRs

• refactor: decouple comet from modules #21382: Involves modifications to service definitions, which may relate to the changes in the bank module's service handling.
• refactor(core): re-add handlers #21575: Enhances message handling, potentially connecting to the new modular approach in the main PR.
• refactor: remove viper as a direct dependency #21635: Focuses on configuration management, which aligns with the changes in the buf.gen.gogo.yaml file.
• refactor(server/v2): kill viper from server components #21663: Continues the effort to eliminate Viper dependency, relevant to the modularity goals of the main PR.
• chore(x/staking): revert proto breakage #21666: Reverts changes causing protocol breakage, ensuring compatibility with existing APIs, which may relate to the main PR's modifications.

Suggested labels

C:x/accounts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[julienrbrt]

Tracked by #21683

[julienrbrt]

Tracked by #21682

[hieuvubk]

LGTM

[akhilkumarpilli]

lgtm