Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert DefaultGasAdjustment to var allowing customization of the value #17395

Closed
wants to merge 1 commit into from

Conversation

GAtom22
Copy link
Contributor

@GAtom22 GAtom22 commented Aug 15, 2023

Description

Closes: #XXXX

When using the flag --gas auto and the current DefaultGasAdjustment, txs always return an out of gas error. Consequently, to submit the transaction successfully, the user always needs to specify a gas adjustment factor greater than the default.

This PR introduces the change to make this default value a variable, so each project can update this value to fit its needs.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@GAtom22 GAtom22 requested a review from a team as a code owner August 15, 2023 16:58
@github-actions github-actions bot added the C:CLI label Aug 15, 2023
@GAtom22 GAtom22 changed the title chore: convert DefaultGasAdjustment to var to allow customization of the value chore: convert DefaultGasAdjustment to var allowing customization of the value Aug 15, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems quite hacky for me.

I'd rather have this implemented: #17253 and have chains set the default in the client.toml.

Happy to remove my R4C if others think otherwise.

@alexanderbez
Copy link
Contributor

Agree with @julienrbrt here. The default gas adjustment is highly dependent on the chain's state anyway. It doesn't always fail.

@julienrbrt
Copy link
Member

Thanks for your contribution.
I'll implement #17253 which will solve your issue in a nicer way.

@julienrbrt julienrbrt closed this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants