Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare v0.50 rc #17384

Merged
merged 6 commits into from
Aug 18, 2023
Merged

chore: prepare v0.50 rc #17384

merged 6 commits into from
Aug 18, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Aug 14, 2023

Description

Closes: #17282

Chores

  • Sort each category in the changelog by decreasing pr/issue number
  • Bump all modules to the latest on simapp
  • (follow-up) Bump all modules to use RC tags
  • (follow-up) Bump SimApp to use RC tagged modules

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez
Copy link
Contributor

LET'S GOOOOOOO!

@julienrbrt julienrbrt marked this pull request as ready for review August 18, 2023 12:25
@julienrbrt julienrbrt requested a review from a team as a code owner August 18, 2023 12:25
Copy link
Member Author

@julienrbrt julienrbrt Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import re

# Define a regular expression to match the [#] pattern
pattern = re.compile(r'\[#(\d+)\]')

# Read the file and extract the number from each line
lines = []
with open('filename.txt', 'r') as f:
    prevmatch = 10000000000000
    for line in f:
        match = pattern.search(line)
        if match:
            number = int(match.group(1))
            lines.append((number, line))
            prevmatch = number
        else:
            lines.append((prevmatch, line))

# Sort the lines based on the extracted numbers in decreasing order
sorted_lines = [line for _, line in sorted(lines, reverse=True)]

# Write the sorted lines back to the file
with open('filename.txt', 'w') as f:
    f.writelines(sorted_lines)

GitHub Copilot Chat did most of that. I then copied each category into a temporary file and let the script sort it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At final we should remove the PRs that have already been included in point versions in the meantime.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@julienrbrt julienrbrt enabled auto-merge (squash) August 18, 2023 14:01
@julienrbrt julienrbrt merged commit 2754730 into release/v0.50.x Aug 18, 2023
39 of 42 checks passed
@julienrbrt julienrbrt deleted the julien/changelog-050-rc branch August 18, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants