Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collections): do not error when iterating empty collections #17290

Merged
merged 6 commits into from
Aug 7, 2023

Conversation

testinginprod
Copy link
Contributor

Description

Closes: #17289


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@testinginprod testinginprod marked this pull request as ready for review August 4, 2023 13:16
@testinginprod testinginprod requested a review from a team as a code owner August 4, 2023 13:16
@julienrbrt
Copy link
Member

julienrbrt commented Aug 4, 2023

We can probably remove this now too:

if errors.Is(err, ErrInvalidIterator) {
_, err = io.WriteString(writer, "]")
return err
}

Copy link
Collaborator

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @testinginprod!

@testinginprod testinginprod added this pull request to the merge queue Aug 7, 2023
Merged via the queue into main with commit b61c72f Aug 7, 2023
43 of 47 checks passed
@testinginprod testinginprod deleted the tip/collections/adjust_iter_behaviour branch August 7, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(collections): do not error when iterating an empty collection
3 participants