Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime): allow to properly register non app wiring modules #17284

Merged
merged 5 commits into from
Aug 7, 2023
Merged

fix(runtime): allow to properly register non app wiring modules #17284

merged 5 commits into from
Aug 7, 2023

Conversation

julienrbrt
Copy link
Member

Description

Verified the ability to register non app wiring enabled modules with runtime.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Aug 3, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner August 3, 2023 23:36
@github-actions

This comment has been minimized.

Sign in to view
tac0turtle
tac0turtle approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing, this is super useful for cosmwasm to not be blocked on ibc migrating.

@julienrbrt julienrbrt added this pull request to the merge queue Aug 7, 2023
Merged via the queue into main with commit 60198f0 Aug 7, 2023
49 checks passed
@julienrbrt julienrbrt deleted the julien/runtime branch August 7, 2023 11:09
mergify bot pushed a commit that referenced this pull request Aug 7, 2023
@julienrbrt @mergify
fix(runtime): allow to properly register non app wiring modules (#17284)
09e7111 
(cherry picked from commit 60198f0)
@mergify mergify bot mentioned this pull request Aug 7, 2023
Merged
mergify bot pushed a commit that referenced this pull request Aug 7, 2023
@julienrbrt @mergify
fix(runtime): allow to properly register non app wiring modules (#17284)
ab54d9e 
(cherry picked from commit 60198f0)

# Conflicts:
#	CHANGELOG.md
#	runtime/app.go
#	runtime/module.go
#	scripts/init-simapp.sh
@mergify mergify bot mentioned this pull request Aug 7, 2023
Merged
julienrbrt added a commit that referenced this pull request Aug 7, 2023
@mergify @julienrbrt
fix(runtime): allow to properly register non app wiring modules (back…
c56cd8a 
…port #17284) (#17304)

Co-authored-by: Julien Robert <[email protected]>
julienrbrt added a commit that referenced this pull request Aug 7, 2023
@mergify @julienrbrt
fix(runtime): allow to properly register non app wiring modules (back…
56f5b59 
…port #17284) (#17305)

Co-authored-by: Julien Robert <[email protected]>
@PoisonPhang PoisonPhang mentioned this pull request Sep 12, 2023
Merged
@dadamu dadamu mentioned this pull request Sep 22, 2023
Merged
19 tasks
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@testinginprod testinginprod Awaiting requested review from testinginprod

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release Type: Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienrbrt @tac0turtle