Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate e2e/evidence away from testify suite #14553

Merged
merged 5 commits into from
Jan 10, 2023

Conversation

samricotta
Copy link
Contributor

@samricotta samricotta commented Jan 9, 2023

Description

Closes: #14548


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@samricotta samricotta requested a review from a team as a code owner January 9, 2023 17:01
@samricotta samricotta changed the title refactor: migrate away from testify Migrate e2e/evidence away from testify suite Jan 9, 2023
@samricotta samricotta changed the title Migrate e2e/evidence away from testify suite Migrate e2e/evidence away from testify suite Jan 9, 2023
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

tests/e2e/evidence/cli_test.go Outdated Show resolved Hide resolved
s.network.Cleanup()
}

func (s *E2ETestSuite) TestGetQueryCmd() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one

@julienrbrt julienrbrt changed the title Migrate e2e/evidence away from testify suite refactor: migrate e2e/evidence away from testify suite Jan 9, 2023
julienrbrt
julienrbrt previously approved these changes Jan 9, 2023
@julienrbrt julienrbrt dismissed their stale review January 9, 2023 17:52

approved by mistake

if tc.expectErr {
s.Require().Error(err)
} else {
s.Require().NoError(err)
Copy link
Member

@julienrbrt julienrbrt Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
s.Require().NoError(err)
assert.NilError(t, err)

These should still be migrated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending julien's comment #14553 (comment)

Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few missing things.

f := initFixture(t)
defer f.network.Cleanup()

val := s.network.Validators[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
val := s.network.Validators[0]
val := f.network.Validators[0]

for name, tc := range testCases {
tc := tc

s.Run(name, func(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
s.Run(name, func(t *testing.T) {
t.Run(name, func(t *testing.T) {


out, err := clitestutil.ExecTestCLICmd(clientCtx, cmd, tc.args)
if tc.expectErr {
s.Require().Error(err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use assert

s.Require().NoError(err)
}

s.Require().Contains(strings.TrimSpace(out.String()), tc.expectedOutput)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace with assert

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one nit

@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tac0turtle tac0turtle enabled auto-merge (squash) January 10, 2023 14:08
@tac0turtle tac0turtle merged commit ea26add into main Jan 10, 2023
@tac0turtle tac0turtle deleted the sam/evidence-e2e branch January 10, 2023 14:12
0xmuralik pushed a commit to 0xmuralik/cosmos-sdk that referenced this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate e2e/evidence away from testify suite
6 participants