refactor: migrate e2e/evidence away from testify suite
#14553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samricotta
changed the title
samricotta
changed the title
e2e/evidence away from testify suite
julienrbrt
previously requested changes
Jan 9, 2023
julienrbrt
reviewed
Jan 9, 2023
| s.network.Cleanup() | ||
| } | ||
|
|
||
| func (s *E2ETestSuite) TestGetQueryCmd() { |
julienrbrt
changed the title
e2e/evidence away from testify suitee2e/evidence away from testify suite
samricotta
force-pushed
the
sam/evidence-e2e
branch
from
4ac6500
to
7df36d2
Compare
alexanderbez
approved these changes
Jan 9, 2023
julienrbrt
previously approved these changes
Jan 9, 2023
julienrbrt
reviewed
Jan 9, 2023
tests/e2e/evidence/cli_test.go
Outdated
| if tc.expectErr { | ||
| s.Require().Error(err) | ||
| } else { | ||
| s.Require().NoError(err) |
There was a problem hiding this comment.
Suggested change
| s.Require().NoError(err) | |
| assert.NilError(t, err) |
These should still be migrated.
likhita-809
approved these changes
Jan 10, 2023
atheeshp
reviewed
Jan 10, 2023
tests/e2e/evidence/cli_test.go
Outdated
| f := initFixture(t) | ||
| defer f.network.Cleanup() | ||
|
|
||
| val := s.network.Validators[0] |
There was a problem hiding this comment.
Suggested change
| val := s.network.Validators[0] | |
| val := f.network.Validators[0] |
tests/e2e/evidence/cli_test.go
Outdated
| for name, tc := range testCases { | ||
| tc := tc | ||
|
|
||
| s.Run(name, func(t *testing.T) { |
There was a problem hiding this comment.
Suggested change
| s.Run(name, func(t *testing.T) { | |
| t.Run(name, func(t *testing.T) { |
tests/e2e/evidence/cli_test.go
Outdated
|
|
||
| out, err := clitestutil.ExecTestCLICmd(clientCtx, cmd, tc.args) | ||
| if tc.expectErr { | ||
| s.Require().Error(err) |
tests/e2e/evidence/cli_test.go
Outdated
| s.Require().NoError(err) | ||
| } | ||
|
|
||
| s.Require().Contains(strings.TrimSpace(out.String()), tc.expectedOutput) |
julienrbrt
reviewed
Jan 10, 2023
|
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #14548
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change