-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace testify with gotest.tools
in e2e/authz
#14502
Conversation
gotest.tools
in e2e/authz
…into ap/authz-gotest.tools
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, one nit!
Have you noticed a performance bump/hit due to the re-creation of the fixtures for each test? Or the parallelization lower that?
func (s *E2ETestSuite) TearDownSuite() { | ||
s.T().Log("tearing down e2e test suite") | ||
s.network.Cleanup() | ||
func (f *fixture) TearDownSuite(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a better name for this, I think
@@ -2,6 +2,8 @@ package authz | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add the e2e
build tag, in each file, now that cli_test.go
is deleted.
So it turns out it significantly increase in the test running time. It has been decided to do not migrate everything to away testify suite, given that we'll eventually create/use an e2e framework instead. |
see comment above, I think we should close this.
Closing this as synced on Slack |
Description
ref. #14561 #12332
Closes: #14489
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change