Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace testify with gotest.tools in e2e/authz #14502

Closed
wants to merge 8 commits into from

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Jan 5, 2023

Description

ref. #14561 #12332
Closes: #14489


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp changed the title WIP tests refactor: Replace testify with gotest.tools in e2e/authz Jan 9, 2023
@atheeshp atheeshp marked this pull request as ready for review January 9, 2023 12:16
@atheeshp atheeshp requested a review from a team as a code owner January 9, 2023 12:16
@sonarcloud
Copy link

sonarcloud bot commented Jan 9, 2023

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

julienrbrt
julienrbrt previously approved these changes Jan 9, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one nit!

Have you noticed a performance bump/hit due to the re-creation of the fixtures for each test? Or the parallelization lower that?

func (s *E2ETestSuite) TearDownSuite() {
s.T().Log("tearing down e2e test suite")
s.network.Cleanup()
func (f *fixture) TearDownSuite(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a better name for this, I think

@@ -2,6 +2,8 @@ package authz

Copy link
Member

@julienrbrt julienrbrt Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the e2e build tag, in each file, now that cli_test.go is deleted.

@julienrbrt
Copy link
Member

julienrbrt commented Jan 9, 2023

lgtm, one nit!

Have you noticed a performance bump/hit due to the re-creation of the fixtures for each test? Or the parallelization lower that?

So it turns out it significantly increase in the test running time. It has been decided to do not migrate everything to away testify suite, given that we'll eventually create/use an e2e framework instead.
We can focus on small suite to remove at first, which will instead make us cut our CI time: #14561

@julienrbrt julienrbrt dismissed their stale review January 9, 2023 23:51

see comment above, I think we should close this.

@julienrbrt
Copy link
Member

Closing this as synced on Slack

@julienrbrt julienrbrt closed this Jan 10, 2023
@julienrbrt julienrbrt deleted the ap/authz-gotest.tools branch January 10, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace testify with gotest.tools in e2e/authz
2 participants