Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
  • Loading branch information
facundomedica and alexanderbez authored Aug 2, 2023
1 parent 500a3a4 commit 44fdaf8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/rfc/rfc-002-optimistic-execution.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,14 @@ The execution context needs to have the following information:
- The block proposal (`abci.RequestFinalizeBlock`)
- Termination and completion signal for the OE goroutine

The OE goroutine would run on top of a cached branch of the KVStore (which is the default behavior for `FinalizeBlock` as we only write to the underlying store once we've reached the end).
The OE goroutine would run on top of a cached branch of the root multi-store (which is the default behavior for `FinalizeBlock` as we only write to the underlying store once we've reached the end).

The OE goroutine would periodically check if a termination signal has been sent to it, and stops if so. Once the OE goroutine finishes the execution it will set the completion signal.

Upon receiving a `ProcessProposal` call, the SDK would adopt the following procedure if OE is enabled:

```
abort any running OE goroutine
abort any running OE goroutine and wait for goroutine exit
if height > initial height:
set OE fields
kick off an OP goroutine that optimistically process the proposal
Expand Down

0 comments on commit 44fdaf8

Please sign in to comment.