-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tape Recorders #512
Tape Recorders #512
Conversation
RSI Diff Bot; head commit e3e4226 merging into 0253cc3 Resources/Textures/_CD/Objects/Devices/cassette_tapes.rsi
Resources/Textures/_CD/Objects/Devices/tape_recorder.rsi
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick look over of the code and it looks fine, however I have not tested in-game yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conceptually fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i gave up halfway through it but EOF newline everywhere + trailing spaces in comments please...?
Content.Client/_CD/TapeRecorder/Ui/TapeRecorderBoundUserInterface.cs
Outdated
Show resolved
Hide resolved
Content.Client/_CD/TapeRecorder/Ui/TapeRecorderBoundUserInterface.cs
Outdated
Show resolved
Hide resolved
Content.Client/_CD/TapeRecorder/Ui/TapeRecorderBoundUserInterface.cs
Outdated
Show resolved
Hide resolved
personally, I'd say make it longer then a minute |
Went through and addressed most of Milon's reviews, everything else I either didn't have time for, don't know how to properly do, or don't think matter enough. Everything I didn't do is left unresolved, so should be noticeable. |
More review fixing has been done, everything else I'm not sure how to do or if its worth doing, so let me know. |
I will look at this in a bit, clearly I need to look it over a bit better. (I only really skimmed it before because I figured wizden would have caught most of it). |
Thats what I thought too, guess I was mistaken. |
Feel free to ping me on the discord if you have any questions or need help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry... most of these you should be able to get rider to fix for you automatically. I know you are not the best with c# so feel free to ask me here or on discord if you have any questions.
Resources/Prototypes/_CD/Roles/Jobs/Civilian/private_investigator.yml
Outdated
Show resolved
Hide resolved
I know we said it on discord already but wow, how did this get so far without these fixes? |
Everything left I'm not sure the best way to fix (this includes test fails), I'm happy to sit down and get some help, or just look at you fixing things. Just let me know. |
Right now the tests are failing because there are compiler errors. |
1cc84e1
to
e3e4226
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay from me if tests pass.
About the PR
Adds taperecorders from wizden PR space-wizards/space-station-14#32234
Also gives the PI role two cassets and a tape recorder.
Added a voice recorder and playback device that uses analog audio cassettes. Players can record their conversations, up to 60 seconds in real-time length, and store the recordings on the cassettes. Players can toggle between recording and playback. If a message is too long to be said towards the end of the tape, it will be cut off partway through.
Why / Balance
This fits well with a HRP setting, allowing detectives to perform interviews, reports to do the same, PIs have more tools available to them.
Technical details
From the wizden PR:
Active bool changed to ActiveTapeRecorder so it can be queried for
UI uses RadioOptions instead of making them manually
most of the state is just gotten from the component instead of being sent in every bui state
it also stores the used speech verb now
From what I believe the PR was based on:
Tape recorder hears all spoken words within a range of 4 tiles, whispers are only audible within 1 tile.
Messages are recorded onto the tape cassette, correctly handling the voice changer
Tape recorder can be swapped between playback, recording and rewinding modes - and then used in-hand to start/stop that mode
Tapes hold 3 minutes of audio, and the recorder will auto stop when the limit is reached
A tape can be damaged, which will corrupt a random entry - it must then be repaired (respooled) with a pen or screwdriver before it can be played again. Corrupted entries will remain corrupted.
On each damage event, a single message will have ~25% of its contents replaced with '#', the same message will be progressively more corrupted if its chosen on multiple damage events.
Media
Changelog
Tape recorders have been added, they are capable of recording brief snippets of speech. They can be found around in security lockers, on PIs, or crafted in lathes. Cassettes with recordings on them can be attacked to destroy some of their stored data, such as who was speaking or specific characters, they can be repaired to be playable again by using a screwdriver on them.