DEVC-627 | Handle optional data field #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skylax1
approved these changes
Feb 6, 2024
corva-alex-s
approved these changes
Feb 6, 2024
|
@ville We've added filtering to stream time events, do we need one for depth events too? |
|
|
||
| return values | ||
|
|
||
| @pydantic.validator("records", pre=True) | ||
| def validate_records(cls, v): | ||
| if isinstance(v, List): |
There was a problem hiding this comment.
Is it a good idea long-term to use typing.List in isinstance checks? Simple list might be more robust, especially, if we migrate to 3.9+
There was a problem hiding this comment.
But this change will break SDK for old Dev Center apps which are still on Python3.8 or am I missing anything?
There was a problem hiding this comment.
It won't, e.g. below we use simple dict in isinstance check - same thing can be used here
oleksii-symon-corva-ai
approved these changes
Feb 7, 2024
No need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Some old apps send events with empty data field which causes error like this one.
Changes
Going forward, once event with empty data is received, no payload validation is raised.
DEVC-627
TODO