feat(dri-1028): add proportion and strokes_rate unit types (#10)

* feat(dri-1028): add proportion and strokes_rate unit types

* feat(dri-1028): fix arcmin typo

* feat(dri-1028): add Hz alias to angular_velocity 1/s

src/corva_unit_converter/converter.py

@@ -24,8 +24,10 @@
     "power": definitions.power.rule,
     "pressure": definitions.pressure.rule,
     "pressure_gradient": definitions.pressure_gradient.rule,
+    "proportion": definitions.proportion.rule,
     "revolution_per_volume": definitions.revolution_per_volume.rule,
     "speed": definitions.speed.rule,
+    "strokes_rate": definitions.strokes_rate.rule,
     "temperature": definitions.temperature.rule,
     "time": definitions.time.rule,
     "torque": definitions.torque.rule,

src/corva_unit_converter/definitions/__init__.py

@@ -23,8 +23,10 @@
     power,
     pressure,
     pressure_gradient,
+    proportion,
     revolution_per_volume,
     speed,
+    strokes_rate,
     temperature,
     time,
     torque,
@@ -58,8 +60,10 @@
     "power",
     "pressure",
     "pressure_gradient",
+    "proportion",
     "revolution_per_volume",
     "speed",
+    "strokes_rate",
     "temperature",
     "time",
     "torque",

src/corva_unit_converter/definitions/angle.py

@@ -38,7 +38,7 @@
       "name": {
          "singular": "arcminute",
          "plural": "arcminutes",
-         "display": "acrmin"
+         "display": "arcmin"
       },
       "to_anchor": 1/60,
       "aliases": [

src/corva_unit_converter/definitions/angular_velocity.py

@@ -13,7 +13,8 @@
         },
         "to_anchor": 60,
         "aliases": [
-            "1/s"
+            "1/s",
+            "Hz"
         ]
     },
     "rev/s": {

src/corva_unit_converter/definitions/proportion.py

@@ -0,0 +1,39 @@
+metric = imperial = {
+   "%": {
+      "name": {
+         "singular": "%",
+         "plural": "%",
+         "display": "%"
+      },
+      "to_anchor": 1,
+      "aliases": [
+         "%"
+      ]
+   },
+   "Fraction": {
+      "name": {
+         "singular": "Fraction",
+         "plural": "Fraction",
+         "display": "Fraction (0-1)"
+      },
+      "to_anchor": 100,
+      "aliases": [
+         "0-1"
+      ]
+   }
+}
+
+rule = {
+   "metric": metric,
+   "imperial": imperial,
+   "_anchors": {
+      "metric": {
+         "unit": "%",
+         "ratio": 1
+      },
+      "imperial": {
+         "unit": "%",
+         "ratio": 1
+      }
+   }
+}

src/corva_unit_converter/definitions/strokes_rate.py

@@ -0,0 +1,56 @@
+metric = imperial = {
+   "strokes/min": {
+      "name": {
+         "singular": "stroke per minute",
+         "plural": "stroke per minute",
+         "display": "strokes/min"
+      },
+      "to_anchor": 1,
+      "aliases": [
+        "strokes/min",
+        "spm",
+        "1/m"
+      ]
+   },
+   "strokes/sec": {
+      "name": {
+         "singular": "stroke per second",
+         "plural": "stroke per second",
+         "display": "strokes/sec"
+      },
+      "to_anchor": 60,
+      "aliases": [
+        "strokes/sec",
+        "sps",
+        "1/s"
+      ]
+   },
+   "strokes/h": {
+      "name": {
+         "singular": "stroke per hour",
+         "plural": "stroke per hour",
+         "display": "strokes/h"
+      },
+      "to_anchor": 1/60,
+      "aliases": [
+        "strokes/h",
+        "sph",
+        "1/h"
+      ]
+   }
+}
+
+rule = {
+   "metric": metric,
+   "imperial": imperial,
+   "_anchors": {
+      "metric": {
+         "unit": "strokes/min",
+         "ratio": 1
+      },
+      "imperial": {
+         "unit": "strokes/min",
+         "ratio": 1
+      }
+   }
+}

tests/test_proportion.py

@@ -0,0 +1,11 @@
+from .utils import convert_units
+
+# test cases
+cases = [
+    {"from": "%", "amount": 1, "to": "Fraction", "expected": 0.01},
+    {"from": "Fraction", "amount": 1, "to": '%', "expected": 100},
+]
+
+
+def test():
+    convert_units(cases)

tests/test_strokes_rate.py

@@ -0,0 +1,20 @@
+from .utils import convert_units
+
+# Test cases
+cases = [
+    {"from": "strokes/min", "amount": 1, "to": "strokes/sec",
+     "expected": 0.016666666666666666},
+    {"from": "strokes/min", "amount": 1, "to": "strokes/h", "expected": 60},
+
+    {"from": "strokes/sec", "amount": 1, "to": "strokes/min", "expected": 60},
+    {"from": "strokes/sec", "amount": 1, "to": "strokes/h", "expected": 3600},
+
+    {"from": "strokes/h", "amount": 1, "to": "strokes/sec",
+     "expected": 0.0002777777777777778},
+    {"from": "strokes/h", "amount": 1, "to": "strokes/min",
+     "expected": 0.016666666666666666},
+]
+
+
+def test():
+    convert_units(cases)