Add CI and make tests externally runnable #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmoseley
reviewed
Jun 21, 2024
|
|
||
| declare global { | ||
| // eslint-disable-next-line no-var | ||
| var testClient: CortexClient; |
There was a problem hiding this comment.
Why not import this where needed? This will pollute the global scope for non-test code as well.
jmoseley
approved these changes
Jun 21, 2024
|
@jmoseley will follow up in another PR doing this via an import. Want to lock in CI now before we start making more changes to the SDK today. But agree this is a good point and I will update accordingly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
testtest:fastandtest:citargets:devand:prodtargets - these are for us only, and external contributors won't be able to run these scripts, but want to maintain them for convenienceNote: had to disable the list content tests due to some bugs that I found in the API. I believe we're following up on that tomorrow.