Use the same eslint config as API #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBoyle
approved these changes
Jun 20, 2024
|
To be able to get that behaviour, they recommend using prettier. I can get that hooked up here and in the API. |
|
I do think having a minimal set of shared formatting rules enforced in CI is a good idea. I don't really care what the formatting is, I'd just like for it to be minimally opinionated and automatically enforced. mainly just want PRs to be only related to the core logic that is changing and to not have to include formatting changes, which having some CI automation should enforce. |
|
I totally agree. I'm personally a fan of prettier, and it integrates smoothly with vscode. |
|
@EvanBoyle what do you think of that? |
jmoseley
commented
Jun 20, 2024
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "recommendations": ["esbenp.prettier-vscode"] | |||
There was a problem hiding this comment.
This will prompt devs to install the plugin.
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/cortexclick/cortex/pull/186