Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement listContent #3

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Implement listContent #3

merged 4 commits into from
Jun 20, 2024

Conversation

jmoseley
Copy link
Contributor

Implement client.listContent()

@jmoseley jmoseley requested a review from EvanBoyle June 20, 2024 20:00
EvanBoyle
EvanBoyle reviewed Jun 20, 2024
View reviewed changes
Copy link
Member

@EvanBoyle EvanBoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! a few comments for you to consider.

content.ts Outdated Show resolved Hide resolved
content.ts Outdated Show resolved Hide resolved
content.test.ts Outdated Show resolved Hide resolved
EvanBoyle
EvanBoyle approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@EvanBoyle EvanBoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, but good to go other than that! 🚀

content.ts Show resolved Hide resolved
@jmoseley jmoseley merged commit 89522fc into main Jun 20, 2024
2 checks passed
@jmoseley jmoseley deleted the jeremy/153 branch June 20, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanBoyle EvanBoyle EvanBoyle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmoseley @EvanBoyle