-
Notifications
You must be signed in to change notification settings - Fork 34
update all dependencies #46
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,3 +14,5 @@ | |
.glide/ | ||
|
||
bin/ | ||
.idea/ | ||
issue-sync | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm this should not be here. All binaries should be compiles directly in `bin. If not, we have some build system bug There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yea it currently builds in the same directory as source. I can look into that. I'll remove this from the pr. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,7 +56,7 @@ func CompareComments(config cfg.Config, ghIssue github.Issue, jIssue jira.Issue, | |
} | ||
// matches[0] is the whole string, matches[1] is the ID | ||
matches := jCommentIDRegex.FindStringSubmatch(jComment.Body) | ||
id, _ := strconv.Atoi(matches[1]) | ||
id, _ := strconv.ParseInt(matches[1], 10, 64) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not from this PR,but we need to give this module some TLC and check all returned errors. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep. My upcoming PRs add features as well as more thorough error handling and I'm currently working on unit tests. It might prove difficult to slice the upcoming work into small PRs (I'll do my best obviously) but included in those changes are some minor improvements in various parts of the code. |
||
if *ghComment.ID != id { | ||
continue | ||
} | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for some editor files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I use IntelliJ which creates editor files under that directory.