bios: Handle empty pttype from lsblk output #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Not tested yet) |
cgwalters
force-pushed
the
main-option-pttype
branch
from
b9b9882
to
c5e96a7
Compare
|
I pushed a change to fix compilation - would obviously be good to test in the failing scenario for real, but we could also add a unit test fixture JSON. |
|
Thanks. I was setting up VMs to test this but got distracted by something else. Will hopefully test tomorrow. |
travier
force-pushed
the
main-option-pttype
branch
2 times, most recently
from
cb0daa1
to
fe4b06f
Compare
|
I've added a small unit test and manually verified that this works on Fedora Silverblue Rawhide BIOS & UEFI. |
zram, sr0 (CD/DVD) and LUKS devices generally don't use partitions, thus don't have a partition table and thus don't have a partition table type so this field may be null. Fixes: coreos#739 Signed-off-by: Colin Walters <[email protected]>
travier
force-pushed
the
main-option-pttype
branch
from
fe4b06f
to
f8504ba
Compare
HuijingHei
added a commit
to HuijingHei/bootupd
that referenced
this pull request
Oct 10, 2024
This is to include coreos#740.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zram, sr0 (CD/DVD) and LUKS devices generally don't use partitions, thus don't have a partition table and thus don't have a partition table type so this field may be null.
Fixes: #739