feat(loader): rename fullReload to exit

cordiverse · Feb 19, 2024 · d280231 · d280231
1 parent f77fb13
commit d280231
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/packages/hmr/src/index.ts b/packages/hmr/src/index.ts
@@ -106,15 +106,15 @@ class Watcher extends Service {
 
       if (isEntry) {
         if (this.ctx.loader.internal!.loadCache.has(filename)) {
-          this.ctx.loader.fullReload()
+          this.ctx.loader.exit()
         } else {
           const config = await loader.readConfig()
           this.ctx.root.state.update(config)
           this.ctx.emit('config')
         }
       } else {
         if (this.externals.has(filename)) {
-          this.ctx.loader.fullReload()
+          this.ctx.loader.exit()
         } else if (this.ctx.loader.internal!.loadCache.has(filename)) {
           this.stashed.add(filename)
           triggerLocalReload()

diff --git a/packages/loader/src/index.ts b/packages/loader/src/index.ts
@@ -14,6 +14,8 @@ namespace NodeLoader {
 }
 
 class NodeLoader extends Loader<NodeLoader.Options> {
+  static readonly exitCode = 51
+
   async readConfig() {
     // restore process.env
     for (const key in process.env) {
@@ -50,7 +52,7 @@ class NodeLoader extends Loader<NodeLoader.Options> {
     }
   }
 
-  fullReload(code = Loader.exitCode) {
+  exit(code = NodeLoader.exitCode) {
     const body = JSON.stringify(this.envData)
     process.send?.({ type: 'shared', body }, (err: any) => {
       if (err) this.app.emit('internal/error', 'failed to send shared data')

diff --git a/packages/loader/src/shared.ts b/packages/loader/src/shared.ts
@@ -63,8 +63,6 @@ export namespace Loader {
   }
 }
 
-  static readonly exitCode = 51
-
 export abstract class Loader<T extends Loader.Options = Loader.Options> extends Service<Entry[]> {
   // process
   public baseDir = process.cwd()
@@ -86,7 +84,6 @@ export abstract class Loader<T extends Loader.Options = Loader.Options> extends
   private store = new WeakMap<any, string>()
 
   abstract import(name: string): Promise<any>
-  abstract fullReload(code?: number): void
 
   constructor(public app: Context, public options: T) {
     super(app, 'loader', true)
@@ -278,6 +275,8 @@ export abstract class Loader<T extends Loader.Options = Loader.Options> extends
   unwrapExports(module: any) {
     return module?.default || module
   }
+
+  exit() {}
 }
 
 export function group(ctx: Context, config: Entry[]) {