Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements #285

Merged
merged 12 commits into from
Nov 12, 2024
Merged

Various improvements #285

merged 12 commits into from
Nov 12, 2024

Conversation

celaus
Copy link
Contributor

@celaus celaus commented Nov 11, 2024

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@celaus celaus requested a review from a team as a code owner November 11, 2024 14:48
lootag
lootag previously approved these changes Nov 11, 2024
View reviewed changes
lootag
lootag previously approved these changes Nov 11, 2024
View reviewed changes
lootag
lootag previously approved these changes Nov 12, 2024
View reviewed changes
@celaus celaus mentioned this pull request Nov 12, 2024
Closed
2 tasks
@celaus celaus merged commit 3cc38ad into master Nov 12, 2024
6 of 7 checks passed
@celaus celaus deleted the IAC-335 branch November 12, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lootag lootag lootag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@celaus @lootag