fix: cds-1580 fix Otel ECS-EC2 configuration (#182)

* fixed cdot entry command * added pprof and removed deprecated logging exporter * changelog * removed latest tag from example
coralogix · Oct 8, 2024 · 23da25b · 23da25b
1 parent 791dc94
commit 23da25b
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,15 @@
 # Changelog
 
+## v2.0.1
+### 🧰 Bug fixes 🧰
+- Fixed ecs-ec2 module, adjusted cdot image command to `--config env:OTEL_CONFIG`
+- Removed latest flag from ecs-ec2 module example.
+- Removed deprecated logging exporter from ecs-ec2 module otel configs.
+
+### 💡 Enhancements 
+- Added pprof extension to default ecs-ec2 otel configurations.
+
+
 ## v2.0.0
 ### 🛑 Breaking changes 🛑
 - Remove deprecated modules: cloudwatch-logs, S3 and kinesis

diff --git a/examples/ecs-ec2/ecs-ec2.tf b/examples/ecs-ec2/ecs-ec2.tf
@@ -4,7 +4,7 @@ provider "aws" {
 module "otel_ecs_ec2_coralogix" {
   source                   = "coralogix/aws/coralogix//modules/ecs-ec2"
   ecs_cluster_name         = "test-lab-cluster"
-  image_version            = "latest"
+  image_version            = "v0.3.1"
   memory                   = 256
   coralogix_region         = "EU1"
   custom_domain            = null

diff --git a/modules/ecs-ec2/main.tf b/modules/ecs-ec2/main.tf
@@ -105,6 +105,7 @@ resource "aws_ecs_task_definition" "coralogix_otel_agent" {
         value : local.otel_config
       }
     ],
+    command: ["--config", "env:OTEL_CONFIG"],
     healthCheck : {
       command : ["CMD-SHELL", "nc -vz localhost 13133 || exit 1"]
       startPeriod : 30

diff --git a/modules/ecs-ec2/otel_config.tftpl.yaml b/modules/ecs-ec2/otel_config.tftpl.yaml
@@ -96,15 +96,17 @@ exporters:
     - "aws.ecs.docker.name"
     - "docker.name"
     timeout: 30s
-  logging:
+  debug:
     verbosity: detailed
 
 extensions:
   health_check:
+  pprof:
 
 service:
   extensions:
     - health_check
+    - pprof
   telemetry:
     logs:
       level: warn

diff --git a/modules/ecs-ec2/otel_config_metrics.tftpl.yaml b/modules/ecs-ec2/otel_config_metrics.tftpl.yaml
@@ -83,7 +83,8 @@ processors:
     override: false
 
 exporters:
-  logging:
+  debug:
+    verbosity: detailed
   coralogix:
     domain: "$CORALOGIX_DOMAIN"
     private_key: "$PRIVATE_KEY"
@@ -101,10 +102,12 @@ exporters:
 
 extensions:
   health_check:
+  pprof:
 
 service:
   extensions:
     - health_check
+    - pprof
   telemetry:
     logs:
       level: warn