Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cds-1666 Add support for Assuming Role, Custom Role and Parameter to select Concurrency Limit #117

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

cds-1666 Add support for Assuming Role, Custom Role and Parameter to select Concurrency Limit #117

wants to merge 24 commits into from
+654 −305

Conversation

daidokoro
Copy link
Contributor

  • Add new variable LambdaAssumeRoleARN
  • added support for AssumeRole, Resrved Conrrent Execution parameter and remved circular dependency on DeadletterQueue
  • changelog
  • added aws_sdk_sts
  • updated readme
  • updated clients mod to support assume role for S3 and ECR clients
  • cargo fmt
  • added AssumeRole variable to config
  • added override condition for assume role and cargo fmt

Description

Fixes #

How Has This Been Tested?

Checklist:

  • I have updated the versions in the SemanticVersion in template.yaml
  • I have updated the CHANGELOG.md
  • I have created necessary PR to Terraform Module Repository (https://github.com/coralogix/terraform-coralogix-aws) if needed
  • This change does not affect any particular component (e.g. it's CI or docs change)

@daidokoro daidokoro requested a review from a team as a code owner November 9, 2024 12:08
coralogix-concourse and others added 15 commits November 9, 2024 14:09
@coralogix-concourse
align cargo.toml version with template version
e5be797
@guyrenny
allow ReservedConcurrentExecutions to have no value
63ad31c
@guyrenny
remove add_role function from custom lambda code
cb64c9f
@guyrenny
add update_lambda_role function to custom lambda
2c1a2f0
@daidokoro
Adjusted Kinesis Condition, Added ReservedConcurrencyLimit as an AWS:…
74c9bb7 
…:Novalue condition, Add additional custom resource Waiter to add delay after Role is updated with the Policy, Moved lambda Policy into its own block.
@daidokoro
removed role update and reservced concurrency limit functions
41b8c51
@guyrenny
Add permissions to kinesis integration, remove function update_lambda…
90e07c6 
…_role from custom resource code
@guyrenny
Add the lambda permissions to create log group
17451e6
@guyrenny
Add to dlq test permission to access S3 bucket, fix permission to pri…
a66530c 
…vatelink
@guyrenny
fix permissions in lambda policy
d4625ff
@guyrenny
update readme file
b78da06
@daidokoro
removed comment
ccebf20
@daidokoro
updated readme with info on Role Parameters
61cebc4
@daidokoro
removed unneeded function
49b6725
@daidokoro
removed unused import
4884116
@daidokoro daidokoro changed the title cds-1666 Add support for Assuming Role and Parameter to select Concurrency Limit cds-1666 Add support for Assuming Role, Custom Role and Parameter to select Concurrency Limit Nov 14, 2024
juan-coralogix
juan-coralogix approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@juan-coralogix juan-coralogix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan-coralogix juan-coralogix juan-coralogix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daidokoro @juan-coralogix @guyrenny @coralogix-concourse