Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDS-1549] allow matches with govcloud for arn of aws secretmanager #115

Merged
merged 3 commits into from
Oct 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## v1.0.14 / 2024-01-10
### 🧰 Bug fixes 🧰
- Allow matches with arn of aws secretmanager in govcloud, previously only matched with public cloud secretmanager arn

## v1.0.13 / 2024-11-08
### 🧰 Bug fixes 🧰
- Allow the lambda to use the runtime `provided.al2`, by changing the binary build of cargo to a version that will support it in the Makefile. Add a parameter `FunctionRunTime` to allow users to choose the function runtime
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "coralogix-aws-shipper"
version = "1.0.13"
version = "1.0.14"
edition = "2021"

[dependencies]
Expand Down
2 changes: 1 addition & 1 deletion src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ async fn main() -> Result<(), Error> {

// if APIKey provided is an ARN, get the APIKey from Secrets Manager
let api_key_value = config.api_key.token().to_string();
if api_key_value.starts_with("arn:aws:secretsmanager:") {
if api_key_value.starts_with("arn:aws") && api_key_value.contains(":secretsmanager") {
config.api_key = config::get_api_key_from_secrets_manager(&aws_config, api_key_value)
.await
.map_err(|e| e.to_string())?;
Expand Down
2 changes: 1 addition & 1 deletion template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Metadata:
- kinesis
- cloudfront
HomePageUrl: https://coralogix.com
SemanticVersion: 1.0.13
SemanticVersion: 1.0.14
SourceCodeUrl: https://github.com/coralogix/coralogix-aws-shipper

AWS::CloudFormation::Interface:
Expand Down
Loading