Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CDS-1549] allow matches with govcloud for arn of aws secretmanager #115

Merged
merged 3 commits into from
Oct 8, 2024
Merged

[CDS-1549] allow matches with govcloud for arn of aws secretmanager #115

merged 3 commits into from
Oct 8, 2024

Conversation

ryantanjunming
Copy link
Contributor

@ryantanjunming ryantanjunming commented Oct 1, 2024 •
edited
Loading

Description

Fixes #

How Has This Been Tested?

Checklist:

  • I have updated the versions in the SemanticVersion in template.yaml
  • I have updated the CHANGELOG.md
  • I have created necessary PR to Terraform Module Repository (https://github.com/coralogix/terraform-coralogix-aws) if needed
  • This change does not affect any particular component (e.g. it's CI or docs change)

@ryantanjunming ryantanjunming requested a review from a team as a code owner October 1, 2024 03:41
@CLAassistant
Copy link

CLAassistant commented Oct 1, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

daidokoro
daidokoro approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@daidokoro daidokoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daidokoro
Copy link
Contributor

daidokoro commented Oct 1, 2024 •
edited
Loading

@ryantanjunming Approved but we should probably add an internal test for govcloud ARNs vs normal. I'll create an internal task for this.

juan-coralogix
juan-coralogix approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@juan-coralogix juan-coralogix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryantanjunming ryantanjunming merged commit 1bfb2a6 into master Oct 8, 2024
15 checks passed
@ryantanjunming ryantanjunming deleted the fix/cds-1549 branch October 8, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan-coralogix juan-coralogix juan-coralogix approved these changes

@daidokoro daidokoro daidokoro approved these changes

Assignees
No one assigned
Labels
run-test-MSK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ryantanjunming @CLAassistant @daidokoro @juan-coralogix @guyrenny