-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specify grpc as appprotocol in cfn exmaple, needed to properly export traces #166
base: master
Are you sure you want to change the base?
Conversation
Simen Mailund Svendsen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Thank you for your contribution to the repo! Please do adjust the http protocol in your commit and submit your signature on the Contributor License Agreement. |
Updated and signed CLA. For the record, it turned out this was not actually what fixed our issue, but it still helps to properly specify the appProtocol hopefully! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@sMailund Would you be able to resubmit your commits after setting up user signing? Commits need to be signed in order to be merged. |
… traces
Description
During our integration with Coralogix, we were only able to logs, but not able to export traces.
In a call with a Coralogix representative, we were shown example code where the only difference was that appProtocol was specified. It turned out we had copied the example code from this cloudformation template, which didn't specify grpc as appProtocol. After reploying with appprotocol specified, traces started showing up in our Coralogix console.
How Has This Been Tested?
Solved the issue in our case. I would assume other integrators using the same setup with a sidecar in ECS will also need to specify grpc the same way. Feel free to reject this PR if that is not the case!
Checklist: