[12.0][FIX] negative price_tax for refunds #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the subtotal price is negative for refunds in csv exports, the price_tax is still positive. This commit adds the computation of a "signed" price_tax based on the type of invoice.
victor-champonnois
changed the title
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 12.0 #12 +/- ##
==========================================
- Coverage 70.26% 70.05% -0.21%
==========================================
Files 24 24
Lines 528 531 +3
Branches 67 68 +1
==========================================
+ Hits 371 372 +1
- Misses 143 144 +1
- Partials 14 15 +1 ☔ View full report in Codecov by Sentry. |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at b114b52. Thanks a lot for contributing to coopiteasy. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the subtotal price is negative for refunds in csv exports, the price_tax is still positive. This PR computes a "signed" price tax based on the type of invoice.
internal task : https://gestion.coopiteasy.be/web#id=12045&model=project.task&view_type=form&menu_id=
@robinkeunen for review