[16.0] [MIG] hr_timesheet_auto_creation #27

victor-champonnois · 2023-07-21T10:05:06Z

https://gestion.coopiteasy.be/web#id=10959&action=475&active_id=492&model=project.task&view_type=form&menu_id=

…le false

...from github : Elico-Corp 10.0/hr_timesheet_auto_creation

* correct summary * correct website * remove application property (since not a full-fledged application) * remove default installable property * reformat

* fix cause of IntegrityError and remove hack * modify the test to cover this this IntegrityError was due to the fact that the same dict was re-used to create multiple timesheets. during the creation, the provided dict is modified, adding a default follower. this resulted in the same follower being added multiple times (one for each loop iteration), and thus in trying to create multiple follower records with the same values.

hr_timesheet_auto_creation: link existing timesheets (account.analytic.line) to newly automatically created timesheet sheets.

Signed-off-by: Carmen Bianca Bakker <[email protected]>

hr_timesheet_auto_creation/tests/test_timesheet_auto_creation.py

huguesdk

with the last fix in the tests, would using setupClass() instead of setup() work again?

carmenbianca · 2023-09-05T09:08:36Z

hr_timesheet_auto_creation/tests/test_timesheet_auto_creation.py

+        # The loop is a workaround for https://github.com/odoo/odoo/issues/129620
+        # Remove loop when bug is fixed upstream.


Fixed in odoo/odoo#130019

carmenbianca · 2023-09-05T09:09:17Z

hr_timesheet_auto_creation/tests/test_timesheet_auto_creation.py

    def setUp(self):
        super().setUp()


like hugues said, let's change this to setUpClass

robinkeunen · 2023-12-15T13:10:07Z

/ocabot merge patch

github-grap-bot · 2023-12-15T13:10:13Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-27-by-robinkeunen-bump-patch, awaiting test results.

Signed-off-by robinkeunen

robinkeunen · 2023-12-15T13:10:29Z

Oups, should have merged nobump

github-grap-bot · 2023-12-15T13:14:34Z

@robinkeunen your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-27-by-robinkeunen-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

robinkeunen · 2023-12-15T14:32:05Z

/ocabot merge nobump

github-grap-bot · 2023-12-15T14:32:11Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-27-by-robinkeunen-bump-nobump, awaiting test results.

github-grap-bot · 2023-12-15T14:36:29Z

Congratulations, your PR was merged at 226a4e1. Thanks a lot for contributing to coopiteasy. ❤️

victor-champonnois requested review from huguesdk, robinkeunen, carmenbianca and remytms July 21, 2023 10:05

github-grap-bot added the needs review label Jul 25, 2023

elicoidal and others added 25 commits July 25, 2023 16:25

Uploaded modules for migration / harmonizewd manifest / set installab…

963dd00

…le false

[MIG][10.0-Issue175-T23293] hr_timesheet_auto_creation.

1c2b2a1

[IMP] README.

98054f1

[IMP] Improved the code of UT cases to fix the travises.

7d5c55c

[ADD] hr_timesheet_auto_creation / backported from 10.0...

a940bf3

...from github : Elico-Corp 10.0/hr_timesheet_auto_creation

[FIX] hr_timesheet_auto_creation / IntegrityError

e02eda2

[ADD] hr_timesheet_auto_creation : _logger

391c499

[FIX] hr_timesheet_auto_creation: fix rst syntax

d95c8da

[REF] hr_timesheet_auto_creation: flake 8

62e7e60

[10.0][MIG] hr_timesheet_auto_creation: migration to 10.0

db3db07

[11.0][MIG] hr_timesheet_auto_creation: migration to 11.0

6e60970

[12.0][MIG] hr_timesheet_auto_creation: migration to 12.0

fde458f

[IMP] paint it black

a8f3b04

[FIX] correct cron job name

ac637e9

[IMP] improve __manifest__.py

c404f3b

* correct summary * correct website * remove application property (since not a full-fledged application) * remove default installable property * reformat

[IMP] fix some linting errors

9ad426b

[IMP] update contributors list

105a464

[IMP] add fixme

76ae9bf

[FIX] auto creation: link existing timesheets

dde1b8c

hr_timesheet_auto_creation: link existing timesheets (account.analytic.line) to newly automatically created timesheet sheets.

[IMP] pass pre-commit

cddc15e

[REL] hr_timesheet_auto_creation 12.0.1.0.1

135c4c7

[FIX] Run pre-commit

ff79c67

Signed-off-by: Carmen Bianca Bakker <[email protected]>

[UPD] Update hr_timesheet_auto_creation.pot

a6b9977

[FIX] SCRLfs → SC

f04c0b7

Signed-off-by: Carmen Bianca Bakker <[email protected]>

victor-champonnois added 5 commits July 25, 2023 16:25

[IMP] hr_timesheet_auto_creation: pre-commit stuff

7f9a6f1

[MIG] hr_timesheet_auto_creation: Migration to 13.0

92bd396

[MIG] hr_timesheet_auto_creation: Migration to 14.0

fffb693

[MIG] hr_timesheet_auto_creation: Migration to 15.0

073a633

[MIG] hr_timesheet_auto_creation: Migration to 16.0

2a001a1

carmenbianca reviewed Jul 25, 2023

View reviewed changes

hr_timesheet_auto_creation/tests/test_timesheet_auto_creation.py Outdated Show resolved Hide resolved

robinkeunen approved these changes Jul 31, 2023

View reviewed changes

huguesdk reviewed Aug 9, 2023

View reviewed changes

carmenbianca requested changes Sep 5, 2023

View reviewed changes

victor-champonnois added 2 commits September 7, 2023 15:36

[IMP] hr_timesheet_auto_creation: use setupclass rather than setup

8af8ea0

run precommit

7229536

victor-champonnois force-pushed the 16.0-mig-hr_timesheet_auto_creation branch from 6a3c267 to 7229536 Compare September 7, 2023 13:37

victor-champonnois requested a review from carmenbianca September 7, 2023 13:38

carmenbianca approved these changes Sep 8, 2023

View reviewed changes

github-grap-bot added the approved label Sep 8, 2023

github-grap-bot added a commit that referenced this pull request Dec 15, 2023

Merge PR #27 into 16.0

e4a6a23

Signed-off-by robinkeunen

github-grap-bot added the bot is merging ⏳ label Dec 15, 2023

github-grap-bot removed the bot is merging ⏳ label Dec 15, 2023

github-grap-bot added the bot is merging ⏳ label Dec 15, 2023

github-grap-bot merged commit 26f9243 into 16.0 Dec 15, 2023
4 checks passed

github-grap-bot deleted the 16.0-mig-hr_timesheet_auto_creation branch December 15, 2023 14:36

github-grap-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0] [MIG] hr_timesheet_auto_creation #27

[16.0] [MIG] hr_timesheet_auto_creation #27

victor-champonnois commented Jul 21, 2023 •

edited

Loading

huguesdk left a comment

carmenbianca Sep 5, 2023

carmenbianca Sep 5, 2023

robinkeunen commented Dec 15, 2023

github-grap-bot commented Dec 15, 2023

robinkeunen commented Dec 15, 2023

github-grap-bot commented Dec 15, 2023

robinkeunen commented Dec 15, 2023

github-grap-bot commented Dec 15, 2023

github-grap-bot commented Dec 15, 2023

		# The loop is a workaround for https://github.com/odoo/odoo/issues/129620
		# Remove loop when bug is fixed upstream.

[16.0] [MIG] hr_timesheet_auto_creation #27

[16.0] [MIG] hr_timesheet_auto_creation #27

Conversation

victor-champonnois commented Jul 21, 2023 • edited Loading

huguesdk left a comment

Choose a reason for hiding this comment

carmenbianca Sep 5, 2023

Choose a reason for hiding this comment

carmenbianca Sep 5, 2023

Choose a reason for hiding this comment

robinkeunen commented Dec 15, 2023

github-grap-bot commented Dec 15, 2023

robinkeunen commented Dec 15, 2023

github-grap-bot commented Dec 15, 2023

robinkeunen commented Dec 15, 2023

github-grap-bot commented Dec 15, 2023

github-grap-bot commented Dec 15, 2023

victor-champonnois commented Jul 21, 2023 •

edited

Loading