Vine: Function Calls Should Fail on Missing Library #4022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btovar
approved these changes
Jan 13, 2025
|
Hold on, putting together a little test and discovering some corner cases... |
must be reaped immediately, because they won't be seen as child process exits.
the dispatch of a library task, which itself failed.
|
Fixes #3789 |
…ete if the argument is null.
dthain
changed the title
btovar
approved these changes
Jan 14, 2025
|
ready to merge? |
JinZhou5042
approved these changes
Jan 14, 2025
|
I'm done with this one, please merge at your discretion.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add check for missing library into expire_tasks_waiting. Causes function call tasks that cannot possibly match a library to be returned to the called with error
MISSING_LIBRARY. Now, if the user submits a library that fails (and is removed), the corresponding function calls will also return and fail, so that we end up with a concrete failure instead of an endless application hang.Merge Checklist
The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.