Hotfix #4799
Open
Hotfix #4799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
andrasbacsai
commented
Jan 10, 2025
•
andrasbacsai
commented
- feat: log horizon worker name to app deployment jobs.
- fix: better cloud jobs handling.
- fix: add lower timeout (ssh,docker) to jobs which are checking the servers, because it could cause problems if high number of jobs are running.
- chore: package updates.
fix: restrict sentinel endpoint
- Added a new option `--can-i-restart-this-worker` to the `horizon:manage` command. - Implemented logic to check if the current worker can be restarted based on running jobs in the ApplicationDeploymentQueue. - Refactored the command to include a new method `canIRestartThisWorker` for better code organization. - Removed unnecessary dump statement from the CustomJobRepository.
…s function - Updated the isAnyDeploymentInprogress function to check for running jobs based on the current hostname. - Enhanced the logic to return true if any job status is 'unknown' and to provide a clearer output regarding the number of deployments in progress. - Modified the cloud_upgrade.sh script to loop until the deployment status check confirms no ongoing deployments before proceeding with the upgrade.
…eProvider - Updated HorizonServiceProvider to extend from HorizonApplicationServiceProvider for improved functionality. - Added a call to the parent boot method to ensure proper initialization. - Cleaned up the gate method by removing unnecessary whitespace.
…erface - Simplified the job status retrieval process by consolidating logic into a single `getJobStatus` function. - Removed redundant checks and methods from the `CustomJobRepositoryInterface` and `CustomJobRepository`. - Updated the `getHorizonJobStatus` method in `ApplicationDeploymentQueue` to directly utilize the new `getJobStatus` function. - Enhanced the `isThereAJobInProgress` method to improve clarity and maintainability.
… for improved job handling - Removed the private property for application deployment queue ID in ApplicationDeploymentJob and utilized constructor property promotion. - Added a tags method in ApplicationDeploymentJob to properly identify the worker running the job. - Updated HorizonServiceProvider to handle cases where the deployment queue ID is blank, preventing potential errors during job processing. - Cleaned up the isAnyDeploymentInprogress function by removing unnecessary whitespace.
- Removed the temporary unavailability message from the /sentinel/push route to allow for proper handling of authorization without misleading responses. - This change improves the clarity of the API response when the authorization token is not provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.