Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves: GitHub handling and AppServiceProvider #4751

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

peaklabs-dev
Copy link
Member

@peaklabs-dev peaklabs-dev commented Jan 6, 2025

Changes

github.php:

  • fix: GitHub JWT token timing issue
  • refactor: rename functions to make code more clear
  • refactor: use snake case on functions consistently
  • refactor: consolidate code
  • refactor: clearer error handling

AppServiceProvider.php:

  • feat: Configure commands for production
  • feat: Configure modals for better error handling
  • chore: remove unused authentik stuff
  • refactor: move things to separate functions
  • refactor: improve password security by not allowing compromised passwords

Issues

- Remove unused authentik stuff
- Move things to separate functions
- Configure commands for production
- Configure modals for better error handling
- Improve password security by not allowing compromised passwords.
- Rename some things to make it clearer.
- Sort imports
- Rename functions
- Consolidate Code
- Fix: timing issues with JWT tokens
- Clearer error handling
@peaklabs-dev peaklabs-dev marked this pull request as ready for review January 6, 2025 15:47
@peaklabs-dev peaklabs-dev changed the base branch from next to test-pr-#4751 January 6, 2025 15:48
@peaklabs-dev peaklabs-dev merged commit 5c31116 into coollabsio:test-pr-#4751 Jan 6, 2025
1 check passed
@peaklabs-dev peaklabs-dev deleted the fix-git-jwt branch January 6, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant