Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: wakapi.yml #3982

Closed
wants to merge 3 commits into from
Closed

add: wakapi.yml #3982

wants to merge 3 commits into from

Conversation

syofyanzuhad
Copy link

No description provided.

@peaklabs-dev peaklabs-dev added ⚙️ Service Issues requesting or PRs adding/fixing service templates. 💤 Waiting for feedback Issues awaiting a response from the author. labels Oct 23, 2024
@peaklabs-dev
Copy link
Member

Thanks for the PR. Can you please use the Coolify magic for all the env variables that are needed https://coolify.io/docs/knowledge-base/docker/compose#coolifys-magic-environment-variables and also please add a comment and logo to your PR https://coolify.io/docs/contribute/service.

@peaklabs-dev peaklabs-dev changed the base branch from main to next October 23, 2024 13:15
@syofyanzuhad
Copy link
Author

@peaklabs-dev i've update it, please review if there's anything wrong..

Copy link
Member

@peaklabs-dev peaklabs-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the changes as requested in my comments


services:
wakapi:
build: .
Copy link
Member

@peaklabs-dev peaklabs-dev Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work you need an image and not a build

wakapi:
build: .
ports:
- 3000:3000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove port mappings as you now use a domain and the reverse proxy

- smtp_pass
- db_password

db:
Copy link
Member

@peaklabs-dev peaklabs-dev Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please look at how other services implement Postgres and use that logic not this one. For example this is a good implementation:

nextcloud-db:
image: postgres:16-alpine
volumes:
- nextcloud-postgresql-data:/var/lib/postgresql/data
environment:
- POSTGRES_USER=${SERVICE_USER_POSTGRES}
- POSTGRES_PASSWORD=${SERVICE_PASSWORD_POSTGRES}
- POSTGRES_DB=${POSTGRES_DB:-nextcloud}
healthcheck:
test: ["CMD-SHELL", "pg_isready -U $${POSTGRES_USER} -d $${POSTGRES_DB}"]
interval: 5s
timeout: 20s
retries: 10

- WAKAPI_DB_USER=$SERVICE_USER_POSTGRESQL
- WAKAPI_DB_HOST="db"
- WAKAPI_DB_PORT="5432"
- WAKAPI_DB_PASSWORD_FILE="/run/secrets/db_password" # alternatively, set WAKAPI_DB_PASSWORD directly without the use of secrets
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use variables and not a password file like described in the comment


# secrets can be defined either from a local file or from an environment variable defined on the client host (the one that runs `docker compose` command)
# see https://docs.docker.com/compose/how-tos/use-secrets/ for details
secrets:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove everything from line 42 to 51 as it will not be needed anymore

@peaklabs-dev
Copy link
Member

Thank you for your contribution. Due to inactivity, we're closing this PR. If you'd like to revisit this change, feel free to reopen this PR or open a new pull request.

@github-actions github-actions bot removed 💤 Waiting for feedback Issues awaiting a response from the author. ⚙️ Service Issues requesting or PRs adding/fixing service templates. labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants