-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: wakapi.yml #3982
add: wakapi.yml #3982
Conversation
Thanks for the PR. Can you please use the Coolify magic for all the env variables that are needed https://coolify.io/docs/knowledge-base/docker/compose#coolifys-magic-environment-variables and also please add a comment and logo to your PR https://coolify.io/docs/contribute/service. |
@peaklabs-dev i've update it, please review if there's anything wrong.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the changes as requested in my comments
|
||
services: | ||
wakapi: | ||
build: . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not work you need an image
and not a build
wakapi: | ||
build: . | ||
ports: | ||
- 3000:3000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove port mappings as you now use a domain and the reverse proxy
- smtp_pass | ||
- db_password | ||
|
||
db: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please look at how other services implement Postgres and use that logic not this one. For example this is a good implementation:
coolify/templates/compose/nextcloud-with-postgres.yaml
Lines 35 to 47 in dc92fe8
nextcloud-db: | |
image: postgres:16-alpine | |
volumes: | |
- nextcloud-postgresql-data:/var/lib/postgresql/data | |
environment: | |
- POSTGRES_USER=${SERVICE_USER_POSTGRES} | |
- POSTGRES_PASSWORD=${SERVICE_PASSWORD_POSTGRES} | |
- POSTGRES_DB=${POSTGRES_DB:-nextcloud} | |
healthcheck: | |
test: ["CMD-SHELL", "pg_isready -U $${POSTGRES_USER} -d $${POSTGRES_DB}"] | |
interval: 5s | |
timeout: 20s | |
retries: 10 |
- WAKAPI_DB_USER=$SERVICE_USER_POSTGRESQL | ||
- WAKAPI_DB_HOST="db" | ||
- WAKAPI_DB_PORT="5432" | ||
- WAKAPI_DB_PASSWORD_FILE="/run/secrets/db_password" # alternatively, set WAKAPI_DB_PASSWORD directly without the use of secrets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use variables and not a password file like described in the comment
|
||
# secrets can be defined either from a local file or from an environment variable defined on the client host (the one that runs `docker compose` command) | ||
# see https://docs.docker.com/compose/how-tos/use-secrets/ for details | ||
secrets: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove everything from line 42 to 51 as it will not be needed anymore
Thank you for your contribution. Due to inactivity, we're closing this PR. If you'd like to revisit this change, feel free to reopen this PR or open a new pull request. |
No description provided.